Add types to rosidl_cli

[InvincibleRMC]

No description provided.

[sloretz]

@Mergifyio update

[mergify]

update

☑️ Nothing to do

• #commits-behind > 0 [📌 update requirement]
• -closed [📌 update requirement]
• -conflict [📌 update requirement]
• queue-position = -1 [📌 update requirement]

[sloretz]

Pulls: #826
Gist: https://gist.githubusercontent.com/sloretz/fc71d0aad0686a7a81376fbb32e57add/raw/59674849538b9c82b25472c1440de2e3e072fd98/ros2.repos
BUILD args: --packages-up-to rosidl_cli
TEST args: --packages-select rosidl_cli
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14627

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[sloretz]

Mind adding <test_depend>ament_mypy</test_depend> to the package.xml?

ImportError while importing test module '/home/jenkins-agent/workspace/ci_linux/ws/src/InvincibleRMC/rosidl/rosidl_cli/test/test_mypy.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test/test_mypy.py:15: in <module>
    from ament_mypy.main import main
E   ModuleNotFoundError: No module named 'ament_mypy'

[InvincibleRMC]

Mind adding <test_depend>ament_mypy</test_depend> to the package.xml?

ImportError while importing test module '/home/jenkins-agent/workspace/ci_linux/ws/src/InvincibleRMC/rosidl/rosidl_cli/test/test_mypy.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test/test_mypy.py:15: in <module>
    from ament_mypy.main import main
E   ModuleNotFoundError: No module named 'ament_mypy'

oops. Will do

[fujitatomoya]

lgtm

[fujitatomoya]

CI:

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

@fujitatomoya I have address the errors. should be re-runnable now.

[fujitatomoya]

CI:

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

@fujitatomoya I made a change to fix the Windows error.

[InvincibleRMC]

@fujitatomoya This CI should be ready to re-run.

[ahcorde]

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

I see I misunderstood the error but, it should be resolved now.

[fujitatomoya]

cc29d8a should fix the mypy failure.

CI:

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[clalancette]

This PR is causing regressions on Windows: https://ci.ros2.org/view/nightly/job/nightly_win_rel/3191/testReport/junit/(root)/projectroot/test_cli_extension/

Specifically, the code in https://github.com/ros2/rosidl/pull/826/files#diff-6867a0a0c2e4946ffe6fadc04c32c1e9362a9518bac9ca31629c7276d198a13cR24-R58 is not a direct replacement for what was there before (because it was overriding specs, that variable was always guaranteed to exist).

I'm going to propose a revert PR here.

[InvincibleRMC]

Ah I see. I missed setting a default for specs_set. My apologies.

[fujitatomoya]

@ahcorde @InvincibleRMC @clalancette

sorry about this.

I will make sure to run test CI with all dependent packages, it should have been able to detect this UnboundLocalError.