Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust dnf-automatic tests for dnf5 #1399

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented Oct 30, 2023

  • as automatic is a plugin in dnf5, it correctly handles installroot so no need for @no_installroot tag
  • changed the way how automatic is called 'dnf-automatic' -> 'dnf5 automatic'

Requires: rpm-software-management/dnf5#984

This PR only adjusts currently existing tests. We should cover more of the automatic functionality in follow-up pull requests.

@jan-kolarik
Copy link
Member

Seems like the dnf-automatic tests are failing...

@m-blaha
Copy link
Member Author

m-blaha commented Mar 6, 2024

Oh yeah, they use the old automatic.conf location. I'll fix them.

@m-blaha
Copy link
Member Author

m-blaha commented Mar 6, 2024

I also noticed that automatic checks are quite slow due to a bug in network availability detection. Here is the fix: rpm-software-management/dnf5#1298

- as automatic is a plugin in dnf5, it correctly handles installroot so
  no need for @no_installroot tag
- changed the way how automatic is called
  'dnf-automatic' -> 'dnf5 automatic'
@jan-kolarik jan-kolarik self-assigned this Mar 6, 2024
@m-blaha m-blaha force-pushed the mblaha/dnf5-automatic branch from 05aab9d to a1b4508 Compare March 6, 2024 11:21
@m-blaha
Copy link
Member Author

m-blaha commented Mar 6, 2024

The automatic.conf location is now fixed.

@jan-kolarik jan-kolarik merged commit 16c555a into main Mar 6, 2024
4 of 5 checks passed
@jan-kolarik jan-kolarik deleted the mblaha/dnf5-automatic branch March 6, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants