Enable and update some module tests #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkratoch
force-pushed
the
enable-module-tests
branch
from
cb63769 to
1d9105f
Compare
kontura
reviewed
Nov 21, 2023
Comment on lines
-50
to
-51
| cfg = ConfigParser() | ||
| cfg.read(glob.glob(cfgdir + '/*.module')) |
There was a problem hiding this comment.
Since the ConfigParser and glob are no longer used should we also drop their imports?
There was a problem hiding this comment.
Good catch! I removed them.
| @@ -12,8 +13,9 @@ Scenario: Check that only module packages including src are available | |||
| | berry-source | enabled | wood | | | |||
| When I execute dnf with args "repoquery berry" | |||
| Then the exit code is 0 | |||
| And stdout is | |||
| And stdout matches line by line | |||
There was a problem hiding this comment.
I am fine with the change, I am just curious why is it done?
There was a problem hiding this comment.
Ah, for some reason I thought the "<REPOSYNC>" is checked only for "stdout matches line by line" and then forgot to check it and change it back. Thanks.
pkratoch
force-pushed
the
enable-module-tests
branch
from
1d9105f to
4a32c75
Compare
The returned dictionary is now a bit different: in case on an avaialable module (i.e. module that is not enabled nor disabled), the "state" has value "available" instead of empty string.
pkratoch
force-pushed
the
enable-module-tests
branch
from
4a32c75 to
4b427d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1400