Ignore EPERM when setting IMA signature xattr #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I can see that 😄 |
Commit f7142bf placed the test into the --delsign test group which is a very specific thing, and doesn't actually need rpm to be built with IMA to work. Attempting to sign always does.
"file" is not a very meaningful keyword here, "ima" lets us test just these when we need to.
|
Seems the result depends on the kind of container we have: in my local rootless container setting the IMA fails, but in the GH runner matryoshka we're actually root on the VM, the container is privileged and you apparanly can set IMA from inside. Lets see... |
pmatilai
force-pushed
the
ima-perm
branch
3 times, most recently
from
7bf194e to
5c97106
Compare
This lets installations succeed even if the ima plugin happens to be installed in a rootless container, where IMA isn't supported. We can't specifically test for rootless container, but I don't know what other situation would result in EPERM for root when setting IMA so it seems like a reasonable heuristic for this. Testing this is a bit tricky: we expect the install to succeed in all cases, but whether IMA actually gets set depends on the container. Fixes: rpm-software-management#3234
|
Finally! 😆 |
ffesti
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets installations succeed even if the ima plugin happens to be installed in a container, where IMA isn't supported. We don't know it failure was because of a container so this is far from ideal, but failing an install just because some package dragged in the ima plugin as a dependency is worse.
Counter-intuitively, the test verifies that the IMA xattr didn't get installed because that's the expected result, when inside a container.
Fixes: #3234
The first commits are tweaks to a couple of small issues I ran into when looking at this.