Add new check to detect links to scripts #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danigm
force-pushed
the
link-to-shebang
branch
3 times, most recently
from
def6ae6 to
a870674
Compare
This new check looks for links in /usr/bin that points to some script in a non bin path that contains a shebang, and checks if the needed interpreter is included as a requirement, because in that case rpm won't be able to inject the requirement by itself. Fix #1120
danigm
force-pushed
the
link-to-shebang
branch
from
a870674 to
aeb59a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new check looks for links in /usr/bin that points to some script in a non bin path that contains a shebang, and checks if the needed interpreter is included as a requirement, because in that case rpm won't be able to inject the requirement by itself.
Fix #1120