Replace bin in easy tests #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danigm
requested changes
Jul 11, 2024
There was a problem hiding this comment.
The test files should go to test/files folder. we don't need the full directory structure for tests.
The content path usage in the test is not right. Looks like these tests are working, even with these packages that are not exactly the same as what were trying to mock, but that could be because the tests are not checking a lot of things.
There was a problem hiding this comment.
These files should go to test/files folder.
test/mockdata/mock_appdata.py
Outdated
|
|
||
| APPDATA = get_tested_mock_package( | ||
| files={ | ||
| '/usr/share/appdata/broken.appdata.xml': {'content_path': '/usr/share/appdata/broken.appdata.xml'}, |
There was a problem hiding this comment.
The correct path to use after move files to test/files will be:
'/usr/share/appdata/broken.appdata.xml': {'content-path': 'files/broken.appdata.xml'},
And the correct key is content-path not content_path, that's why even with the full system path this is working.
Also, creating a mock file to improve code cleanup of the test_appdata.py file
The files are placed in the test/files directory
Also, creating a mock file to improve code cleanup of the test_dbus_policy.py file
Also, creating a mock file to improve code cleanup of the test_build_root.py file. As for pkg: Move read_with_mmap method to AbstractPkg This method is needed for test_build_root so to be able to use FakePkg here we need this method implemented in both classes Pkg and FakePkg
Also, creating a mock file to improve code cleanup of the test_mixed_ownership.py file. Some necessary changes are made to the pkg.py file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, creating mock files to improve code cleanup of files.