making the changes from PR 315 to the most recent release (0.9.59) to solve floodlight control #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skooj
changed the title
Not at all! Thank you, sorry I've been busy and haven't had a lot of time to look at this. Taking a look now! |
|
Thank you, I can finally update from 0.9.49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the risk of pestering, I am going to make another PR, as it seems this issue continues to get overlooked and the previous pull request (by another user) was never merged.
I was experiencing the issue that was possibly solved with PR 315 for the ability to control the light on my ASH26-W floodlight. Using that fork I was able to get my floodlight to work. However, it was very much an older version and the doorbell button on my AD410 would not trigger in home assistant.
I simply took the changes made to that pull request, applied them to the main branch 0.9.59, and have been using this fork for roughly a week with no issue.
I do not have any other devices aside from my ASH26-W and my AD410, so I am not positive if these changes will break anything else.