fix/custom metadata header alloc #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viglucci
added
the
1.0
Signed-off-by: Kevin Viglucci <[email protected]>
- encodeAndAddCustomMetadata - encodeCustomMetadataHeader Signed-off-by: Kevin Viglucci <[email protected]>
Signed-off-by: Kevin Viglucci <[email protected]>
viglucci
force-pushed
the
fix/custom-metadata-alloc
branch
from
1763bfe to
01e3e2c
Compare
viglucci
added a commit
that referenced
this pull request
Sep 4, 2022
* fix: clear buffer when allocating for custom metadata header * test: add composite metadata tests - encodeAndAddCustomMetadata - encodeCustomMetadataHeader Signed-off-by: Kevin Viglucci <[email protected]>
viglucci
added a commit
that referenced
this pull request
Apr 27, 2023
* fix: clear buffer when allocating for custom metadata header * test: add composite metadata tests - encodeAndAddCustomMetadata - encodeCustomMetadataHeader Signed-off-by: Kevin Viglucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #230
Motivation:
Usage of
Buffer.allocUnsafehad the potential for leaking previously allocated memory in custom metadata headers.Modifications:
Fill buffer allocated for custom metadata header prior to writing.
Result:
Buffer allocated for custom metadata header is prevented from containing values from previously allocated memory.