Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-27: Add the "Custom Search JSON API" along with "Custom Search Site Restricted JSON API" #30

Merged
merged 2 commits into from
Dec 21, 2023
Merged

GH-27: Add the "Custom Search JSON API" along with "Custom Search Site Restricted JSON API" #30

merged 2 commits into from
Dec 21, 2023

Conversation

SH4LIN
Copy link
Contributor

@SH4LIN SH4LIN commented Dec 21, 2023

Overview

  • This PR will add support for the custom search JSON API. This is an optional support so by default plugin will run on "Custom Search Site Restricted JSON API" We have to manually change the search type from Settings > Reading > Search type.
  • It will also add the proper notice on the WP dashboard.
  • Search will work as it is only request URL endpoint will change.

Screenshot(s)/Video(s)

https://github.com/rtCamp/search-with-google/assets/56588503/48a7d72d-702c-4062-aedf-21b26c789476
https://github.com/rtCamp/search-with-google/assets/56588503/08950777-b6dc-45e0-ac8a-b862ec5298ce

Fixes/Covers

vishalkakadiya
vishalkakadiya approved these changes Dec 21, 2023
View reviewed changes
Copy link

@vishalkakadiya vishalkakadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SH4LIN Approved the PR, just address that one feedback.

inc/classes/class-settings.php Outdated Show resolved Hide resolved
@SH4LIN SH4LIN merged commit 32a748f into develop Dec 21, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalkakadiya vishalkakadiya vishalkakadiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SH4LIN @vishalkakadiya