Adding a new example to Routing Service. UDP socket to DDS adapter #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcamposruiz not sure why the lint jobs failed. Where can I find more details so I can fix them? |
added 6 commits
August 6, 2024 11:55
|
@alexcamposruiz can we merge this? |
juanlu-rti
reviewed
Oct 4, 2024
juanlu-rti
reviewed
Oct 4, 2024
juanlu-rti
reviewed
Oct 4, 2024
juanlu-rti
reviewed
Oct 4, 2024
examples/routing_service/udp_socket_adapter/src/SocketConnection.cxx
Outdated
Show resolved
Hide resolved
juanlu-rti
reviewed
Oct 4, 2024
juanlu-rti
reviewed
Oct 4, 2024
juanlu-rti
reviewed
Oct 4, 2024
examples/routing_service/udp_socket_adapter/src/SocketStreamReader.cxx
Outdated
Show resolved
Hide resolved
juanlu-rti
reviewed
Oct 4, 2024
juanlu-rti
reviewed
Oct 4, 2024
examples/routing_service/udp_socket_adapter/src/SocketStreamReader.cxx
Outdated
Show resolved
Hide resolved
juanlu-rti
reviewed
Oct 4, 2024
examples/routing_service/udp_socket_adapter/test/send_shape_to_socket.py
Show resolved
Hide resolved
juanlu-rti
reviewed
Oct 4, 2024
examples/routing_service/udp_socket_adapter/src/SocketInputDiscoveryStreamReader.hpp
Show resolved
Hide resolved
juanlu-rti
requested changes
Oct 4, 2024
|
@juanlu-rti I applied your feedback, let me know what you think! Thanks!! |
fgaranda
requested changes
Oct 8, 2024
examples/routing_service/udp_socket_adapter/src/SocketAdapter.hpp
Outdated
Show resolved
Hide resolved
examples/routing_service/udp_socket_adapter/src/SocketAdapter.cxx
Outdated
Show resolved
Hide resolved
examples/routing_service/udp_socket_adapter/src/SocketInputDiscoveryStreamReader.cxx
Outdated
Show resolved
Hide resolved
examples/routing_service/udp_socket_adapter/src/SocketInputDiscoveryStreamReader.hpp
Outdated
Show resolved
Hide resolved
examples/routing_service/udp_socket_adapter/src/SocketStreamReader.cxx
Outdated
Show resolved
Hide resolved
|
thanks for the feedback, @fgaranda ! I applied all your feedback |
juanlu-rti
reviewed
Oct 29, 2024
juanlu-rti
previously approved these changes
Oct 29, 2024
fgaranda
previously approved these changes
Oct 29, 2024
fgaranda
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently only have an example for a file adapter. This new example provides a UDP socket --> DDS adapter. I have found myself looking for a simple adapter like this one in the past, so hopefully this helps others.
Details and comments
In addition to the adapter, a Python "tester" is included to inject UDP data.
Checks