Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for JRuby. #122

Closed
wants to merge 1 commit into from
Closed

Conversation

dblock
Copy link

@dblock dblock commented Oct 7, 2015

Really just CI, don't merge until green.

fixes #120

@@ -6,3 +6,5 @@ rvm:
- 2.0.0
- 2.1.7
- 2.2.3
- jruby-19mode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be the same as jruby

@grosser
Copy link
Collaborator

grosser commented Oct 7, 2015

yes please! tried this and failed ...

@dblock dblock force-pushed the jruby-support branch 3 times, most recently from ec50f8f to f6de650 Compare October 7, 2015 16:01
@dblock
Copy link
Author

dblock commented Oct 7, 2015

I fixed some of the obvious things. The rest seems harder and I don't care enough, so maybe someone who uses JRuby actively can take a look and finish it? The remaining problems are:

Blockers

  • Binary write/read doesn't match in size, seems like a legit failure.
  • uninitialized constant Rack::Cache::AppEngine::MC::Expiration, I think this is fallout of the jruby-memcached gem too, but I couldn't figure out how it appears otherwise

Other

  • exists? is rewritten because jruby-memcached doesn't support append, Add support for append aurorafeint/jruby-memcached#13
  • I skipped running tests that reached into the depths of the Memcached gem implementation and pulled out @options, but those tests are useful, maybe that should be actually preserved in jruby-memcached.

@dblock dblock closed this Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.3.0 doesn't install on JRuby
2 participants