Gitignore contributors data #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
approved these changes
Jan 15, 2025
It's generated from the rubygems/rubygems repo so it's not necessary to keep it source controlled here.
`rake build` is necessary to generate contributor data file, which is necessary to render the contributors page.
Since we no longer keep the yaml file in source control, I think the `update` part has lost most of its meaning.
deivid-rodriguez
force-pushed
the
gitignore-contributors
branch
from
0249edd to
06f2a4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was while working on this repo, you may get random source control changes whenever the rubygems/rubygems repo gets new contributions. This is inconvenient.
What was your diagnosis of the problem?
My diagnosis was that there's no need to keep this file source control. We can let the repo setup generate it.
What is your fix for the problem, implemented in this PR?
My fix is to let this file be gitignored.
Why did you choose this fix out of the possible options?
I chose this fix because it makes developing in this repo nicer.