Bump bootstrap from 5.1.3 to 5.2.0 #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-boots-brsxmy
deivid-rodriguez
temporarily deployed
to
bundler-site-tnir-boots-0pmnpj
tnir
force-pushed
the
tnir-bootstrap-5.2.0
branch
from
6e0ee5e to
a5e7f53
Compare
tnir
changed the title
tnir
commented
Sep 14, 2022
tnir
force-pushed
the
tnir-bootstrap-5.2.0
branch
from
a5e7f53 to
4574b68
Compare
deivid-rodriguez
force-pushed
the
tnir-bootstrap-5.2.0
branch
from
4574b68 to
3d8bda4
Compare
|
@tnir I fixed bootstrap 5.2.0 compatibility. Issue was introduced by twbs/bootstrap#35679, and I fixed it by forcing a disposal of the popper so that it's properly regenerated. 5.2.1 has a different issue, but I think this is fine to merge. |
deivid-rodriguez
changed the title
deivid-rodriguez
force-pushed
the
tnir-bootstrap-5.2.0
branch
from
3d8bda4 to
66c1f98
Compare
deivid-rodriguez
force-pushed
the
tnir-bootstrap-5.2.0
branch
from
66c1f98 to
ff38ba3
Compare
|
Thanks @deivid-rodriguez for merging this 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstarap 5.2.0 (GA) and 5.2.1 was released: https://blog.getbootstrap.com/2022/07/19/bootstrap-5-2-0/ and https://blog.getbootstrap.com/2022/09/07/bootstrap-5-2-1/
Bootstrap 5.2.1 fixed the regression introduced as below in 5.2.0.
As of 2022-07-25, Bootstrap 5.2.0 had a regression as below, so we cannot upgrade to 5.2.0. Hopefully we can go with 5.2.1.getInstanceon.popoverelement twbs/bootstrap#36837In 5.2.0-beta1, the popover is placed incorrectly on the second attempt twbs/bootstrap#36518Signed-off-by: Takuya Noguchi [email protected]