fix: Ollama is unable to create a knowledge base using a local embedd…

…ing model CherryHQ#630
ruiwarn · Jan 6, 2025 · d884269 · d884269
1 parent bd9bdc5
commit d884269
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/renderer/src/pages/knowledge/components/AddKnowledgePopup.tsx b/src/renderer/src/pages/knowledge/components/AddKnowledgePopup.tsx
@@ -72,6 +72,7 @@ const PopupContainer: React.FC<Props> = ({ title, resolve }) => {
         } catch (error) {
           console.error('Error getting embedding dimensions:', error)
           window.message.error(t('message.error.get_embedding_dimensions'))
+          setLoading(false)
           return
         }
 

diff --git a/src/renderer/src/services/KnowledgeService.ts b/src/renderer/src/services/KnowledgeService.ts
@@ -1,7 +1,7 @@
 import type { ExtractChunkData } from '@llm-tools/embedjs-interfaces'
 import AiProvider from '@renderer/providers/AiProvider'
 import { FileType, KnowledgeBase, KnowledgeBaseParams, Message } from '@renderer/types'
-import { isEmpty, take } from 'lodash'
+import { take } from 'lodash'
 
 import { getProviderByModel } from './AssistantService'
 import FileManager from './FileManager'
@@ -10,10 +10,6 @@ export const getKnowledgeBaseParams = (base: KnowledgeBase): KnowledgeBaseParams
   const provider = getProviderByModel(base.model)
   const aiProvider = new AiProvider(provider)
 
-  if (provider.id === 'ollama' && isEmpty(provider.apiKey)) {
-    provider.apiKey = 'empty'
-  }
-
   let host = aiProvider.getBaseURL()
 
   if (provider.type === 'gemini') {
@@ -24,7 +20,7 @@ export const getKnowledgeBaseParams = (base: KnowledgeBase): KnowledgeBaseParams
     id: base.id,
     model: base.model.id,
     dimensions: base.dimensions,
-    apiKey: aiProvider.getApiKey(),
+    apiKey: aiProvider.getApiKey() || 'secret',
     apiVersion: provider.apiVersion,
     baseURL: host
   }