Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check List Membership Implementation #35

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Check List Membership Implementation #35

merged 4 commits into from
Apr 8, 2020

Conversation

amcpanaligan
Copy link
Contributor

#34: Check List Membership

@amcpanaligan amcpanaligan added the enhancement New feature or request label Apr 8, 2020
@amcpanaligan amcpanaligan requested a review from iamEAP April 8, 2020 02:38
@amcpanaligan amcpanaligan self-assigned this Apr 8, 2020
iamEAP
iamEAP suggested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@iamEAP iamEAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @amcpanaligan! A few smaller items.

src/steps/listMembership/check-list-membership.ts Show resolved Hide resolved
src/steps/listMembership/check-list-membership.ts Show resolved Hide resolved
src/steps/listMembership/check-list-membership.ts Outdated Show resolved Hide resolved
test/scenarios/List Membership/Check List Membership.crank.yml Outdated Show resolved Hide resolved
@iamEAP iamEAP merged commit 8202b14 into run-crank:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamEAP iamEAP iamEAP approved these changes

Assignees

@amcpanaligan amcpanaligan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amcpanaligan @iamEAP @apanaligan