Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop party chest version 1.0 #7180

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

pgroenbaek
Copy link
Contributor

Very simple plugin that adds total chest value to the title of the drop party chest interfaces in the party room and clan hall.

This is quite similar to what the bank plugin does to the bank interface title.

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 26, 2024

@YvesW
Copy link
Member

YvesW commented Dec 26, 2024

Seems like this is something we might want to add to core?

@pgroenbaek
Copy link
Contributor Author

Seems like this is something we might want to add to core?

Definitely could be added there, but that's completely up to you guys to decide.

I can make a PR with this in the main runelite repo if you want it there instead. :)

@YvesW
Copy link
Member

YvesW commented Dec 26, 2024

I'd make a core PR, or at least ask in #dev if the maintainers think it belongs in core.

I'd personally also remove the log.info calls (or make them log.debug) but that's my 0.02

@pgroenbaek
Copy link
Contributor Author

I'd make a core PR, or at least ask in #dev if the maintainers think it belongs in core.

I'd personally also remove the log.info calls (or makke them log.debug) but that's my 0.02

Okay, I'll ask there.

And yeah, the log.info calls are from the plugin generator template. I'll be removing those.

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 27, 2024
@pgroenbaek
Copy link
Contributor Author

I have created a PR with this as a core plugin in the runelite repo.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jan 7, 2025
@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 7, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jan 11, 2025
@pgroenbaek
Copy link
Contributor Author

Adam was of the opinion that this would probably fit better as a plugin hub plugin.

I've updated this PR to the latest commit with changes suggested by Yves if you think this kind of functionality is relevant to have as a plugin hub plugin. This is completely up to you of course. :)

@LlemonDuck LlemonDuck merged commit 2ffb2fa into runelite:master Jan 11, 2025
3 checks passed
@pgroenbaek pgroenbaek deleted the drop-party-chest-plugin branch January 12, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants