-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop party chest version 1.0 #7180
Drop party chest version 1.0 #7180
Conversation
New plugin |
Seems like this is something we might want to add to core? |
Definitely could be added there, but that's completely up to you guys to decide. I can make a PR with this in the main runelite repo if you want it there instead. :) |
I'd make a core PR, or at least ask in #dev if the maintainers think it belongs in core. I'd personally also remove the log.info calls (or make them log.debug) but that's my 0.02 |
Okay, I'll ask there. And yeah, the log.info calls are from the plugin generator template. I'll be removing those. |
I have created a PR with this as a core plugin in the runelite repo. |
Adam was of the opinion that this would probably fit better as a plugin hub plugin. I've updated this PR to the latest commit with changes suggested by Yves if you think this kind of functionality is relevant to have as a plugin hub plugin. This is completely up to you of course. :) |
Very simple plugin that adds total chest value to the title of the drop party chest interfaces in the party room and clan hall.
This is quite similar to what the bank plugin does to the bank interface title.