Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raids death indicator #7229

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

vikke1234
Copy link
Contributor

@vikke1234 vikke1234 commented Jan 11, 2025

Similarly to nylo death indicators and tzhaar hp, this plugin is a death indicator for ToA. The idea is to make it able to reliably confirm whether an enemy dies or not. It highlights akkha as a range (e.g. shadow) hit procs shadows.

It accomplishes this by computing the internal fraction for hitpoints.

Currently this only supports Ampken and Akkha. The enemy data for other rooms is a placeholder for v1.x, this is an initial PoC.

@runelite-github-app
Copy link

runelite-github-app bot commented Jan 11, 2025

@vikke1234
Copy link
Contributor Author

re-running workflows

@vikke1234 vikke1234 closed this Jan 11, 2025
@vikke1234 vikke1234 reopened this Jan 11, 2025
@iProdigy
Copy link
Member

not a full review but: on plugin shutdown you should do overlayManager.remove(overlay); and wsClient.unregisterMessage(EntityDamaged.class);

@vikke1234
Copy link
Contributor Author

alright, I'll fix it tomorrow 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants