Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #![start] attribute #478

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Remove #![start] attribute #478

merged 2 commits into from
Jan 23, 2025
+3 −39

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jan 23, 2025

The #![start] attribute has been removed in
rust-lang/rust#134299.

@ehuss
Remove #![start] attribute
3de1d4e 
The `#![start]` attribute has been removed in
rust-lang/rust#134299.
@ehuss
Copy link
Contributor Author

ehuss commented Jan 23, 2025

@RalfJung Can you please give this a review?

RalfJung
RalfJung reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know which starting points must be used where, main worked for everything except wasm in my PR. I guess WinMain is specific for GUI applications on Windows, no idea where _start would be used.

src/beneath-std.md Outdated Show resolved Hide resolved
@ehuss
Copy link
Contributor Author

ehuss commented Jan 23, 2025

Thanks @RalfJung!

@ehuss ehuss added this pull request to the merge queue Jan 23, 2025
Merged via the queue into rust-lang:master with commit e031105 Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@traviscross traviscross traviscross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehuss @RalfJung @traviscross