Pin remark-lint-maximum-line-length version
#12668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
flip1995
reviewed
Apr 11, 2024
.github/workflows/remark.yml
Outdated
| @@ -24,7 +24,7 @@ jobs: | |||
| node-version: '18.x' | |||
|
|
|||
| - name: Install remark | |||
| run: npm install remark-cli remark-lint remark-lint-maximum-line-length remark-preset-lint-recommended remark-gfm | |||
| run: npm ci | |||
There was a problem hiding this comment.
I don't really like having package.json in the repo just for this. Couldn't you change the npm install command to add the version.
Suggested change
| run: npm ci | |
| run: npm install remark-cli remark-lint remark-lint-maximum-line-length@"^3.1.3" remark-preset-lint-recommended remark-gfm |
Note the @"^3.1.3" in the suggestion.
There was a problem hiding this comment.
I didn't think mixing old versions of lints with the new remark-lint would work but it seems to be fine so I'll use that
Alexendoo
force-pushed
the
remark-version
branch
from
e585dbe to
fb2e827
Compare
Alexendoo
changed the title
remark-lint-maximum-line-length version
|
Let's try this. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pins the remark versions to the ones from before the most recent set of updates which errors on some line lengths that aren't clear how to resolve
Currently blocking CI
changelog: none