Skip to content
This repository has been archived by the owner on Jul 3, 2020. It is now read-only.

FIX issue #198: wrong linker used #199

Closed
wants to merge 2 commits into from
Closed

FIX issue #198: wrong linker used #199

wants to merge 2 commits into from

Conversation

s-d-m
Copy link
Contributor

@s-d-m s-d-m commented Jan 15, 2019

according to https://stackoverflow.com/questions/52646860 the -gcc-toolchain
flag is now required starting with ndk-r18

@s-d-m
Copy link
Contributor Author

s-d-m commented Jan 15, 2019

Note: I didn't try this change with older versions of the ndk.
The proper fix here might be to conditionally add this flag to the linker based on the ndk version used.

s-d-m added 2 commits January 15, 2019 23:41
@s-d-m
Allow using cargo-apk as a cargo subcommand
bc92e95 
This is a workaround such that calling `cargo apk build` will now
work the same as calling `cargo-apk build`.
@s-d-m
FIX issue #198: wrong linker used
3b9f686 
according to https://stackoverflow.com/questions/52646860 the -gcc-toolchain
flag is now required starting with ndk-r18
@s-d-m
Copy link
Contributor Author

s-d-m commented Jul 31, 2019

Closing this pull request as it was fixed by #223.

@s-d-m s-d-m closed this Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s-d-m