Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keybindings for zellij 0.41.x #20

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: keybindings for zellij 0.41.x #20

merged 1 commit into from
Nov 15, 2024

Conversation

dj95
Copy link
Contributor

@dj95 dj95 commented Nov 4, 2024

First of all thanks for your awesome plugin!

In the latest zellij release(0.41.x) there were some changes regards the keybindings. Unfortunately they result in an incompatibility when pressing the key.

I've fixed the issue by migrating to the new zellij-tile version and refactoring the key matcher according to the new API.

I hope I've catched all of the keybinds properly.

In case you are not interested, feel also free to close this PR :)

Cheers!

@jacostag
Copy link

jacostag commented Nov 7, 2024

I just want to mention that I tested the commit and is working great :)
This is the plugin that I use the most.
I am a rust newbie, but I added to Cargo.toml
[profile.release]
opt-level = 3

And compile using cargo build --release

Just to not have debugging in there, do not know if that is ok for zellij plugins

@dj95
Copy link
Contributor Author

dj95 commented Nov 10, 2024

@jacostag Building the plugin with cargo build --release should per default use opt-level = 3.

https://doc.rust-lang.org/cargo/reference/profiles.html#release

My main plugin, I maintain, is also distributed as release build and therefore has the optimizations enabled. Haven't encountered or received any issues so far.

@Borwe
Copy link

Borwe commented Nov 13, 2024

Yup using this, can confirm works fine in new zellij version.

@ondrej-ivanko
Copy link

@rvcas can you please approve this. Thank you.

@rvcas
Copy link
Owner

rvcas commented Nov 15, 2024

Hey sorry everyone, I'll merge this today. Not sure why I didn't notice sooner. I haven't restarted zellij in weeks so I never noticed the update.

@rvcas rvcas merged commit f523ecc into rvcas:main Nov 15, 2024
1 check passed
@rvcas
Copy link
Owner

rvcas commented Nov 15, 2024

New release coming asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants