Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cli_colors to never, auto, always like in cargo #2656

Closed
wants to merge 4 commits into from
Closed

Change cli_colors to never, auto, always like in cargo #2656

wants to merge 4 commits into from

Conversation

levkk
Copy link
Contributor

@levkk levkk commented Nov 29, 2023

Replaces #2654

@levkk levkk mentioned this pull request Nov 29, 2023
Closed
@levkk
Copy link
Contributor Author

levkk commented Nov 29, 2023

Manually tested this with honcho, in the examples/hello project. Works like a charm. I can include a Procfile and a README for additional testing, if you like.

@SergioBenitez
Copy link
Member

There was a deserialization bug that resulted in integers not actually parsing as intended. I fixed that along with added documentation and tests in 7cf8b13. This PR was merged in f4e8987. Thank you for this!

@SergioBenitez SergioBenitez added the pr: merged This pull request was merged manually. label Dec 19, 2023
@levkk levkk deleted the levkk-log-colors-enum branch December 19, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: merged This pull request was merged manually.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levkk @SergioBenitez