Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR attempts to implement changes discussed in #36.
I took the changes proposed by @geiszla in https://github.com/BindrUK/jitsi_meet/tree/platform-view
In addition to iOS NativeView implementation this changes also contain:
I'm still working on the Android part as it's much more tricky than the iOS part. I tried to implement changes from the fork mentioned above but so far failed to get it working as ReactNative parts seem to be outdated.
I also tried to embed it directly but I was not able to do that with the need for wrapping the JitsiMeetView in JitsiMeetActivity.
Notice that I temporarily changed the pubspec.yaml to relative import of jitsi_meet_wrapper_platform_interface. As the changes are in both packages I left it for testing purposes.
This is still work in progress, I will continue implementing the missing android part, but I'm looking forward for any feedback/suggestions/support as my android knowledge is quite limited.
Thank you