Skip to content

Commit

Permalink
Merge branch 'release/0.0.4'
Browse files Browse the repository at this point in the history
  • Loading branch information
DominusKelvin committed Jul 1, 2023
2 parents d1806fb + dd0a4cb commit f3d6421
Show file tree
Hide file tree
Showing 110 changed files with 4,839 additions and 2,736 deletions.
1 change: 1 addition & 0 deletions .commitlintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = { extends: ['@commitlint/config-conventional'] }
22 changes: 22 additions & 0 deletions .github/workflows/prettier.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Prettier

on: [push, pull_request]

jobs:
prettier:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 18

- name: Run npm ci
run: npm ci

- name: Run Prettier
run: npx prettier --config ./.prettierrc.js --write .
4 changes: 4 additions & 0 deletions .husky/commit-msg
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npx --no -- commitlint --edit ${1}
27 changes: 15 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Thank you for taking the time to contribute to our project. We appreciate you!
> **Pull Requests having no issue associated with them will not be accepted. Firstly get an issue assigned, whether it's already opened or raised by you, and then create a Pull Request.**
## Prerequisites

Before you contribute to The Boring JavaScript Stack, make sure you have the following prerequisites:

- Open Source Etiquette: If you've never contributed to an open source project before, have a read of [Basic etiquette](https://developer.mozilla.org/en-US/docs/MDN/Community/Open_source_etiquette) for open source projects.
Expand All @@ -18,6 +19,7 @@ Before you contribute to The Boring JavaScript Stack, make sure you have the fol
---

## How to Contribute 🤔

To contribute to The Boring JavScript Stack, follow these steps:

- Look at the existing [**Issues**](https://github.com/sailscastshq/boring-stack/issues) or create a new issue if you haven't found a suitable one.
Expand All @@ -40,6 +42,7 @@ If you're new to our project, we recommend starting with the [_Good first issue_
### Sending a Pull Request

To ensure a smooth review process, please follow these guidelines:

- Fork (https://help.github.com/articles/fork-a-repo) the repository into your own account.
- In your forked repository, create a new branch: `git checkout -b my-branch develop`
- Make your changes/fixes.
Expand All @@ -51,27 +54,27 @@ To ensure a smooth review process, please follow these guidelines:
>
> ** To ensure a better review experience, we kindly request that you use the following format for the PR title: `[chore]`, `[feat]`, or `[fix]`, followed by a descriptive title. For example, a chore-related change could have a title like `[chore] Update contributing guidelines`. This helps us categorize and understand the nature of the changes made in each PR..**
- Link the issue you have resolved in the Pull Request Template using the following syntax:
- If your Pull Request fixes issue #25, add `Fixes #25` or `Closes #25` to the description.
- If your Pull Request addresses multiple issues, list them using the same syntax (`Fixes #23, Fixes #15`).
- Link the issue you have resolved in the Pull Request Template using the following syntax:
- If your Pull Request fixes issue #25, add `Fixes #25` or `Closes #25` to the description.
- If your Pull Request addresses multiple issues, list them using the same syntax (`Fixes #23, Fixes #15`).

This helps us track and automatically close the relevant issue when your Pull Request is merged.
This helps us track and automatically close the relevant issue when your Pull Request is merged.

### Commits

We highly encourage the use of conventional commits. Here are some examples:
We highly encourage the use of conventional commits. Here are some examples:

- feat: Use this when adding a new feature.
- fix: Use this when resolving any issues in the codebase.
- chore: Use this when adding new links/resources or making minor changes.
(ex. chore: Add 'Privacy Policy' link in footer)
- Please keep your commit messages concise and clear.
- Write commit messages in the present tense, as they represent the current state of the codebase after the changes have been applied.
- feat: Use this when adding a new feature.
- fix: Use this when resolving any issues in the codebase.
- chore: Use this when adding new links/resources or making minor changes.
(ex. chore: Add 'Privacy Policy' link in footer)
- Please keep your commit messages concise and clear.
- Write commit messages in the present tense, as they represent the current state of the codebase after the changes have been applied.

For additional reference, check out [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)

## Your Feedback Matters! 💬

- If you notice any missing information or feel that something is not adequately described, please don't hesitate to create a pull request (PR) or [raise an issue](https://github.com/sailscastshq/boring-stack/issues). Your input helps us improve our guidelines and make the Boring-Stack project even more awesome!

We're thrilled to have you on board. Let's make a difference together! 🚀
We're thrilled to have you on board. Let's make a difference together! 🚀
7 changes: 7 additions & 0 deletions create-sails/actions/frontend.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,14 @@ import { select, isCancel, cancel } from '@clack/prompts'
import color from 'picocolors'

export default async function frontend(argv) {
/**
* @type {('vue' | 'react' | 'svelte')[]}
*/
const supportedFrontends = ['vue', 'react', 'svelte']

/**
* @type {number}
*/
const countOfFrontendFlagsPassed = supportedFrontends.filter(
(frontend) => argv[frontend]
).length
Expand Down
8 changes: 4 additions & 4 deletions create-sails/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ async function main() {

s.start('Copying project files.')
await downloadProject(specifiedProjectName, { frontend: specifiedFrontend })
s.stop(color.green('Template copied!'))
s.stop(color.cyan('Template copied!'))

injectDefaultDek(root)
injectSessionSecret(root)
Expand All @@ -45,11 +45,11 @@ async function main() {
console.log()

if (root !== cwd) {
console.log(` ${color.green(`cd ${path.relative(cwd, root)}`)}`)
console.log(` ${color.cyan(`cd ${path.relative(cwd, root)}`)}`)
}
const packageManager = detectPackageManager()
console.log(` ${color.green(getCommand(packageManager, 'install'))}`)
console.log(` ${color.green('npx sails lift')}`)
console.log(` ${color.cyan(getCommand(packageManager, 'install'))}`)
console.log(` ${color.cyan('npx sails lift')}`)

outro(color.inverse('Enjoy your boring project.'))
process.exit(0)
Expand Down
5 changes: 5 additions & 0 deletions jsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"compilerOptions": {
"checkJs": true
}
}
Loading

0 comments on commit f3d6421

Please sign in to comment.