exclude poko annotations as a runtime dependency

[evant]

This is only needed for compilation

note: excluding this way shows up in the pom file as:

    <dependency>
      <groupId>dev.drewhamilton.poko</groupId>
      <artifactId>poko-annotations-jvm</artifactId>
      <version>0.15.2</version>
      <scope>runtime</scope>
      <exclusions>
        <exclusion>
          <groupId>dev.drewhamilton.poko</groupId>
          <artifactId>*</artifactId>
        </exclusion>
     ....

instead of removing it completely which is a bit strange but it does seem to work fine on the consumer-side.

[saket]

Interesting. Can you help me understand why this is needed? Does it have to do with the way I'm applying poko above? If not, should all projects that use poko do this?

[evant]

the gradle plugin is adding the annotation dependency using implementation instead of compileOnly. It's seems that there's been some back-and-forth on trying to change that which apparently broke something drewhamilton/Poko#163.

Looking at the implementation an alternative would be to use a custom annotation and use compileOnly yourself, which would get rid of the extra pom metadata, but that seems like a lot to set up for something that should be pretty simple imo.

[drewhamilton]

👋 It was switched back to implementation in drewhamilton/Poko#212 because native targets apparently don't have the concept of compileOnly. If Telephoto is Android-only, this should be safe.

If you want to file an issue on Poko to make non-native targets use compileOnly by default (again), I wouldn't hate it!

[drewhamilton]

Ah, it's not Android-only. In that case you'll want to avoid applying this change to native targets.

[evant]

Interesting, yeah I'm using this in an android project which is where I noticed the issue

[evant]

so I checked and while this lib is multiplatform the only other platform is desktop jvm, which I would expect to behave the same way in terms of compilation right? I was going to submit a pr porting the sample app to desktop to prove this out but I couldn't get it working, 😕.

[saket]

Yea I only have desktop and android, but I want to add support for targets once coil becomes stable. I forgot to ask, what's the downside of not merging this?

[evant]

It's not a huge deal but we are tracking our transitive dependencies and it was a surprising add, we did just put in an exclude for now.

implementation("me.saket.telephoto:zoomable:0.7.1") {
    exclude(group = "dev.drewhamilton.poko")
}

[evant]

created drewhamilton/Poko#328 as it might be better to tackle this upstream