Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes on this version worked for myself and others who attended session 5 of the samvera training workshop. however, both rob and jeremy believe it will actually break something. instead, some env variable or something may need to be set to rectify the issue I saw in
v5.4.0
.blocking this from being merged until the 2 issues below are resolved and a new release is cut:
ObjectFactory#search_by_identifier
bug bulkrax#866::ActiveFedora.index_field_mapper.solr_name
search bulkrax#867