Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to support Ruby 3.3 and Rails 7.2 #6913

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

randalldfloyd
Copy link
Contributor

@randalldfloyd randalldfloyd commented Oct 2, 2024

Fixes: #6905 , #6906

Summary

Contains numerous changes required to support Ruby 3.3 and Rails 7.2.
Okay to squash on merge (retain commit messages in message detail)

Detailed Description

Main areas of work

Dealing with constants and Rails 7 autoloader
Lots of issues with specs themselves due to incompatible usages of rspec, factories, etc.
Deprecated methods throughout the code
Upgrading/fixing compatibility with dependencies
Issues with strong parameter handling

Various misc. incompatibilities, see detailed commit message

Copy link

github-actions bot commented Oct 2, 2024

Test Results

    13 files  ±0      13 suites  ±0   2h 48m 36s ⏱️ - 9m 39s
 6 833 tests +1   6 534 ✅ +1  299 💤 ±0  0 ❌ ±0 
18 101 runs  +1  17 624 ✅ +1  477 💤 ±0  0 ❌ ±0 

Results for commit f9968b2. ± Comparison against base commit 3c4a4b5.

This pull request removes 367 and adds 368 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f12b5be6a58>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f3bc6260c88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f442852cf88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f12bbeaf658>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3bc6a5c310>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f44280f7e40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 175c8261-a1ed-43ff-9692-31a4b9fed28c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 839aa930-2d90-41bd-892e-948e40122ee5
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: d75fc326-6597-40a3-b5c6-72db8e0129c2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: c61f0978-f59a-48a8-899a-90f9053dc1c5
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f07ce62b2e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f5b79e21a40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fbd04edec48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f07cd3be4e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f5b82361b88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fbd04effc90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: ca7df509-3a29-4be3-a851-d1810d68ce0e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: b08d9f6a-020c-497d-8953-e9dd92c84b88
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: c5950f12-c861-4e08-aed5-b2f0430ba13b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 8ee6c395-4ba4-4f21-8466-273a912f5ad5
…

♻️ This comment has been updated with latest results.

@cjcolvar cjcolvar force-pushed the ruby-3.3_rails-7.2 branch 2 times, most recently from d2d1d8e to c54a552 Compare October 2, 2024 22:27
@randalldfloyd randalldfloyd force-pushed the ruby-3.3_rails-7.2 branch 12 times, most recently from 9683dc6 to ad0ba7f Compare October 11, 2024 20:00
@randalldfloyd randalldfloyd force-pushed the ruby-3.3_rails-7.2 branch 2 times, most recently from e95df99 to e6bf157 Compare October 15, 2024 20:17
@cjcolvar cjcolvar force-pushed the ruby-3.3_rails-7.2 branch 2 times, most recently from eb34603 to ef66ca8 Compare December 11, 2024 16:19
cjcolvar and others added 5 commits December 13, 2024 00:55
…pport::Dependencies#remove_constant
…ler::Parameters, now deprecated
… default precision
Daniel Pierce and others added 14 commits January 21, 2025 12:04

Unverified

No user is associated with the committer email.
# Conflicts:
#	.dassie/Gemfile
#	.koppie/Gemfile
#	Dockerfile
#	spec/spec_helper.rb

Verified

This commit was signed with the committer’s verified signature.
dlpierce Daniel Pierce

Verified

This commit was signed with the committer’s verified signature.
dlpierce Daniel Pierce
This required removing posix-spawn, reordering the docker user add, and disabling the native alpine packages.

Verified

This commit was signed with the committer’s verified signature.
dlpierce Daniel Pierce
…emoved as Hyrax dependency

Verified

This commit was signed with the committer’s verified signature.
dlpierce Daniel Pierce

Verified

This commit was signed with the committer’s verified signature.
dlpierce Daniel Pierce

Verified

This commit was signed with the committer’s verified signature.
dlpierce Daniel Pierce
…o render properly

Verified

This commit was signed with the committer’s verified signature.
dlpierce Daniel Pierce

Verified

This commit was signed with the committer’s verified signature.
dlpierce Daniel Pierce

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@randalldfloyd randalldfloyd changed the title WIP: Support Ruby 3.3 and Rails 7.2 Upgrade dependencies to support Ruby 3.3 and Rails 7.2 Jan 24, 2025
@randalldfloyd randalldfloyd marked this pull request as ready for review January 24, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Rails 7.2 in Hyrax
3 participants