Skip to content

Commit

Permalink
TSX Linting Fix - Remove tsconfig linting file from eslint config (#218)
Browse files Browse the repository at this point in the history
* Add linting rule to error on raw hex codes

* Add linting exceptions for .tsx files with SVG's

* Add and configure style-lint for erroring on non-variable hex codes

* Refactor forgotten hex codes into color variables

* Add new linting to github workflow

* Remove unused stylelint package, upgrade node version for workflows to work with stylelint

* Better specify github workflow node versions

* Fix node version typo lol

* Update postcss version in package.json

Co-authored-by: Zachar Hankewycz <[email protected]>

* Update lock file to match package.json

* Edit lint error message to be more detailed

* Update lockfile

* Type fix (caught because of linter, now erorrs)

* Update snapshot

* Fix linting for nested tsx files

---------

Co-authored-by: Zachar Hankewycz <[email protected]>
  • Loading branch information
Lucas-Dunker and hankewyczz authored Oct 21, 2023
1 parent 93db6e5 commit 7058839
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
"plugin:react-hooks/recommended"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": "./tsconfig.eslint.json"
},
"plugins": ["@typescript-eslint/eslint-plugin"],
// "parserOptions": {
// "project": "./tsconfig.eslint.json"
// },
"plugins": ["@typescript-eslint"],
"rules": {
"react/react-in-jsx-scope": "off",
"@typescript-eslint/explicit-function-return-type": "off",
Expand Down
2 changes: 2 additions & 0 deletions tsconfig.eslint.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/* 10-16-23: This file currently isn't being used for linting, as it's typically only for monorepos.
Since we want all typescript files to be linted with the same rules, we don't need it! */
{
"extends": "./tsconfig.json",
"include": ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx"]
Expand Down

0 comments on commit 7058839

Please sign in to comment.