Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ap/no notifications husky page #303

Merged
merged 26 commits into from
Dec 4, 2024
Merged

Conversation

ananyaspatil
Copy link
Collaborator

Purpose

Creates an EmptyCard to display for the Empty Notifications page.
When "Search for classes" button is hovered over, crying-husky image changes to happy-husky image.
Includes a placeholder text for "Spring 2023 Notifications", this will need to be changed to actually reflect the semester of notifications being displayed.

Tickets

https://trello.com/c/SoJpDQFG

Contributors

recent commits: @cherman23 @mehallhm
last semester commits: @Anzhuo-W @ananyaspatil

Feature List

Created display for the Empty Notifications page.

  • Created EmptyCard Component: contains display text and a button that redirects to the default search page
  • added crying-husky.svg and happy-husky.svg images
    When "Search for classes" button is hovered over, crying-husky image changes to happy-husky image.
  • Added isHovering const to EmptyCard
  • Added logic to update husky image to happy when OnMouseEnter is true for "search for classes" button
  • Added a margin above EmptyCard Component
  • Heading text updates to reflect the semester of notifications being displayed (should always be the most recent semester).

Pictures (will need to be updated)

No Hover:
image

Hover:
image

Reviewers

@cherman23 @mehallhm @ananyaspatil @nickpfeiffer05 @Anzhuo-W

Anzhuo-W and others added 26 commits March 30, 2024 03:01
Properly migrate styles to new _EmptyCard file
- fix styles in classcard, use function notation

- Redirect Empty card to empty results page.
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
searchneu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 11:52pm

Copy link
Contributor

@cherman23 cherman23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ananyaspatil ananyaspatil merged commit 5b7bac8 into master Dec 4, 2024
5 checks passed
@ananyaspatil ananyaspatil deleted the AP/no-notifications-husky-page branch December 4, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants