Bump mysql-connector-python from 8.1.0 to 8.3.0 #890

dependabot · 2024-01-17T07:51:59Z

Bumps mysql-connector-python from 8.1.0 to 8.3.0.

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

codecov · 2024-02-20T13:18:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7090be3) 91.12% compared to head (eae5839) 91.13%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #890   +/-   ##
========================================
  Coverage    91.12%   91.13%           
========================================
  Files           61       61           
  Lines         4261     4265    +4     
  Branches       469      469           
========================================
+ Hits          3883     3887    +4     
  Misses         312      312           
  Partials        66       66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dasunpubudumal · 2024-02-20T14:00:55Z

@dependabot rebase

dependabot · 2024-02-20T14:00:58Z

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

dasunpubudumal · 2024-02-20T14:05:04Z

@dependabot recreate

dasunpubudumal · 2024-02-20T14:05:43Z

@dependabot rebase

dependabot · 2024-02-20T14:05:47Z

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

dasunpubudumal · 2024-02-20T14:57:59Z

@dependabot recreate

Bumps [mysql-connector-python](http://dev.mysql.com/doc/connector-python/en/index.html) from 8.1.0 to 8.3.0. --- updated-dependencies: - dependency-name: mysql-connector-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

dasunpubudumal · 2024-02-21T11:19:15Z

Code changes are related to the following updates:

DPL-1100 - As developers we need to fix and merge the dependencies to reduce security problems and reduce techncial debt #909 (comment)
DPL-1100 - As developers we need to fix and merge the dependencies to reduce security problems and reduce techncial debt #909 (comment)

sdjmchattie

My main concern here is having to add so many additional mock methods just because our external dependency decided to change their internal functionality. I think perhaps this is a bit of a code smell at this point. Perhaps we should look at how we might wrap the MySQLConnection so we only have to mock the methods we actually call on it during testing. Something like https://stackoverflow.com/a/42799362

tests/db/test_mysql.py

StephenHulme

Looks like a surprisingly difficult minor upgrade!

The frequent use of casting strike's me as a (possibly unavoidable) code smell, but there is one particular place where it can be easily cleaned up.

Pipfile

tests/file_processing/test_file_processing.py

dasunpubudumal · 2024-02-21T11:41:17Z

Looks like a surprisingly difficult minor upgrade!

The frequent use of casting strike's me as a (possibly unavoidable) code smell, but there is one particular place where it can be easily cleaned up.

I personally feel that the developers didn't communicate enough the breadth of the changes they have done. These changes aren't even in their changelogs. I basically had to check out their source code and compare the diffs to figure this out.

dasunpubudumal · 2024-02-21T11:51:40Z

My main concern here is having to add so many additional mock methods just because our external dependency decided to change their internal functionality. I think perhaps this is a bit of a code smell at this point. Perhaps we should look at how we might wrap the MySQLConnection so we only have to mock the methods we actually call on it during testing. Something like https://stackoverflow.com/a/42799362

I agree with this. I'll try to write to write a wrapper on top of MySQLConnection for this purpose.

sdjmchattie

Thanks for the changes. It looks really good.

If the wrapper turns out to be a bit of a task, don't do it here. Make a new ticket for it as technical debt and bring it up in the retrospective next week.

StephenHulme

Thanks for the refactoring, much better!

dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 17, 2024

dependabot bot mentioned this pull request Jan 17, 2024

Bump mysql-connector-python from 8.1.0 to 8.2.0 #882

Closed

dependabot bot force-pushed the dependabot/pip/mysql-connector-python-8.3.0 branch 2 times, most recently from fb80a7c to 9aa2d15 Compare January 18, 2024 10:12

dependabot bot force-pushed the dependabot/pip/mysql-connector-python-8.3.0 branch 3 times, most recently from eb72c0b to 5cf10b0 Compare February 7, 2024 09:15

dependabot bot force-pushed the dependabot/pip/mysql-connector-python-8.3.0 branch 4 times, most recently from e68926f to 18f3458 Compare February 12, 2024 19:24

stevieing mentioned this pull request Feb 16, 2024

DPL-1100 - As developers we need to fix and merge the dependencies to reduce security problems and reduce techncial debt #909

Closed

dependabot bot force-pushed the dependabot/pip/mysql-connector-python-8.3.0 branch from 8afc757 to 8e275f7 Compare February 20, 2024 14:06

dependabot bot force-pushed the dependabot/pip/mysql-connector-python-8.3.0 branch from 0d8902e to 410edfb Compare February 20, 2024 15:02

dasunpubudumal added 3 commits February 20, 2024 17:00

Testing out implementing mock methods using MagicMock

8287dcc

Fixing issues with black and mypy

4a7d941

Fixing issues with black and mypy

acc8a66

dasunpubudumal requested review from sdjmchattie and StephenHulme February 21, 2024 11:17

dasunpubudumal linked an issue Feb 21, 2024 that may be closed by this pull request

DPL-1100 - As developers we need to fix and merge the dependencies to reduce security problems and reduce techncial debt #909

Closed

sdjmchattie requested changes Feb 21, 2024

View reviewed changes

tests/db/test_mysql.py Show resolved Hide resolved

StephenHulme requested changes Feb 21, 2024

View reviewed changes

Pipfile Show resolved Hide resolved

tests/file_processing/test_file_processing.py Outdated Show resolved Hide resolved

Refactoring minor updates

eae5839

sdjmchattie approved these changes Feb 21, 2024

View reviewed changes

StephenHulme approved these changes Feb 21, 2024

View reviewed changes

dasunpubudumal merged commit 27f8796 into develop Feb 21, 2024
10 checks passed

dasunpubudumal deleted the dependabot/pip/mysql-connector-python-8.3.0 branch February 21, 2024 15:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump mysql-connector-python from 8.1.0 to 8.3.0 #890

Bump mysql-connector-python from 8.1.0 to 8.3.0 #890

dependabot bot commented on behalf of github Jan 17, 2024 •

edited

Loading

codecov bot commented Feb 20, 2024 •

edited

Loading

dasunpubudumal commented Feb 20, 2024

dependabot bot commented on behalf of github Feb 20, 2024

dasunpubudumal commented Feb 20, 2024

dasunpubudumal commented Feb 20, 2024

dependabot bot commented on behalf of github Feb 20, 2024

dasunpubudumal commented Feb 20, 2024

dasunpubudumal commented Feb 21, 2024

sdjmchattie left a comment

StephenHulme left a comment

dasunpubudumal commented Feb 21, 2024

dasunpubudumal commented Feb 21, 2024

sdjmchattie left a comment

StephenHulme left a comment

Bump mysql-connector-python from 8.1.0 to 8.3.0 #890

Bump mysql-connector-python from 8.1.0 to 8.3.0 #890

Conversation

dependabot bot commented on behalf of github Jan 17, 2024 • edited Loading

codecov bot commented Feb 20, 2024 • edited Loading

Codecov Report

dasunpubudumal commented Feb 20, 2024

dependabot bot commented on behalf of github Feb 20, 2024

dasunpubudumal commented Feb 20, 2024

dasunpubudumal commented Feb 20, 2024

dependabot bot commented on behalf of github Feb 20, 2024

dasunpubudumal commented Feb 20, 2024

dasunpubudumal commented Feb 21, 2024

sdjmchattie left a comment

Choose a reason for hiding this comment

StephenHulme left a comment

Choose a reason for hiding this comment

dasunpubudumal commented Feb 21, 2024

dasunpubudumal commented Feb 21, 2024

sdjmchattie left a comment

Choose a reason for hiding this comment

StephenHulme left a comment

Choose a reason for hiding this comment

dependabot bot commented on behalf of github Jan 17, 2024 •

edited

Loading

codecov bot commented Feb 20, 2024 •

edited

Loading