Merge pull request #1425 from sanger/fix-validations-plate-split-tube…

…-racks scRNA - fix for validation triggering prematurely when custom page present
sanger · Oct 25, 2023 · 3d202be · 3d202be
2 parents 4b0ea37 + 1efb6b1
commit 3d202be
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/app/models/labware_creators/plate_split_to_tube_racks.rb b/app/models/labware_creators/plate_split_to_tube_racks.rb
@@ -42,14 +42,13 @@ module LabwareCreators
   #
   # rubocop:disable Metrics/ClassLength
   class PlateSplitToTubeRacks < Base
+    include LabwareCreators::CustomPage
     include SupportParent::PlateOnly
 
-    self.attributes += %i[sequencing_file contingency_file]
-
     self.page = 'plate_split_to_tube_racks'
+    self.attributes += %i[sequencing_file contingency_file]
 
     attr_accessor :sequencing_file, :contingency_file
-
     attr_reader :child_sequencing_tubes, :child_contingency_tubes
 
     validates_nested :well_filter
@@ -71,6 +70,7 @@ class PlateSplitToTubeRacks < Base
       'wells.aliquots,wells.aliquots.sample,wells.downstream_tubes,wells.downstream_tubes.custom_metadatum_collection'
 
     def save
+      # NB. need the && true!!
       super && upload_tube_rack_files && true
     end
 

diff --git a/script/limber b/script/limber
@@ -26,11 +26,7 @@ def build_config
   api = $stdin.gets.chomp
   $stdout.print 'PMB url: '
   pmb = $stdin.gets.chomp
-  {
-    'sequencescape' => url,
-    'api_key' => api,
-    'pmb' => pmb
-  }
+  { 'sequencescape' => url, 'api_key' => api, 'pmb' => pmb }
 end
 
 def run_environment(config)