Merge remote-tracking branch 'origin/develop' into 1352-dpl-865-limbe…

…r-handle-sprint-client-response

.release-version

@@ -1 +1 @@
-3.66.1
+3.67.0

app/models/presenters/donor_pooling_plate_presenter.rb

@@ -5,8 +5,6 @@ module Presenters
   # number of cells by study. If other features are necessary in the presenter,
   # they can be added here or the validation can be moved to the new one.
   class DonorPoolingPlatePresenter < StandardPresenter
-    validates_with Validators::RequiredNumberOfCellsValidator
-
     # The pooling tab is not relevant for this presenter as the wells are already pooled (tab shows future pooling
     # by submission strategy)
     self.pooling_tab = ''

config/initializers/scrna_config.rb

@@ -31,8 +31,6 @@
     7 => 70_000,
     8 => 84_285
   },
-  # Key for the required number of cells metadata stored on Study (in poly_metadata)
-  study_required_number_of_cells_per_sample_in_pool_key: 'scrna_core_pbmc_donor_pooling_required_number_of_cells',
   # Default viability threshold when passing/failing samples (in percent)
   viability_default_threshold: 65,
   # Default total cell count threshold when passing/failing samples

config/purposes/scrna_core_cdna_prep.yml

@@ -120,7 +120,7 @@ LRC GEM-X 5p cDNA PCR XP:
   # close off the submission when the plate is created
   :state_changer_class: StateChangers::AutomaticPlateStateChanger
   :work_completion_request_type:
-    ['limber_scrna_core_cdna_prep_gem_x_5p_pbmc_pools_input', 'limber_scrna_core_cdna_prep_gem_x_5p']
+    ['limber_scrna_core_cdna_prep_gem_x_5p_gems_input', 'limber_scrna_core_cdna_prep_gem_x_5p']
 # faculty input plate (alternate to LRC GEM-X 5p cDNA PCR XP intermediate plate)
 LRC GEM-X 5p cDNA Input:
   :asset_type: plate

spec/models/presenters/donor_pooling_plate_presenter_spec.rb

@@ -76,9 +76,6 @@
   # Constants from config/initializers/scrna_config.rb
   let(:scrna_config) { Rails.application.config.scrna_config }
 
-  let(:study_required_number_of_cells_per_sample_in_pool_key) do
-    scrna_config[:study_required_number_of_cells_per_sample_in_pool_key]
-  end
   let(:required_number_of_cells_per_sample_in_pool) { scrna_config[:required_number_of_cells_per_sample_in_pool] }
 
   subject { Presenters::DonorPoolingPlatePresenter.new(labware:) }
@@ -89,28 +86,6 @@
     source_wells_to_b1.each { |well| allow(well.aliquots.first).to receive(:study).and_return(study_to_b1) }
   end
 
-  context 'when the labware in pending state' do
-    context 'with the required number of cells option for all studies' do
-      # Configure the first study
-      let(:study_to_a1) do
-        poly_metadatum =
-          create(:poly_metadatum, key: study_required_number_of_cells_per_sample_in_pool_key, value: '1000')
-        create(:study_with_poly_metadata, poly_metadata: [poly_metadatum]) # poly_metadata with cell count option
-      end
-
-      # Configure the second study
-      let(:study_to_b1) do
-        poly_metadatum =
-          create(:poly_metadatum, key: study_required_number_of_cells_per_sample_in_pool_key, value: '2000')
-        create(:study_with_poly_metadata, poly_metadata: [poly_metadatum]) # poly_metadata with cell count option
-      end
-
-      it 'does not warn the user about any study' do
-        expect(subject).to be_valid # There are no warnings.
-      end
-    end
-  end
-
   context 'when the labware not in pending state' do
     before { allow(labware).to receive(:state).and_return('passed') }