Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPL-829 pbmc plate to tube rack bed verification #1415

Merged
merged 56 commits into from
Nov 15, 2023
Merged

DPL-829 pbmc plate to tube rack bed verification #1415

merged 56 commits into from
Nov 15, 2023

Conversation

yoldas
Copy link
Member

@yoldas yoldas commented Oct 12, 2023 •
edited
Loading

Closes #

Changes proposed in this pull request

  • Bed verification from PBMC plate to SEQ/SPARE tube racks
  • Tube racks are from metadata of plate well downstream tubes
  • Contingency-only verification using bed reconfiguration in robot
  • State changing for all tubes of tube racks

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@yoldas yoldas linked an issue Oct 12, 2023 that may be closed by this pull request
DPL-829 PBMC plate --> tube rack bed verification #1333
Closed
9 tasks
KatyTaylor
KatyTaylor requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lots of comments but just naming / documentation and questions. Thanks.

app/controllers/robots_controller.rb Outdated Show resolved Hide resolved
app/controllers/robots_controller.rb Outdated Show resolved Hide resolved
app/controllers/robots_controller.rb Outdated Show resolved Hide resolved
config/robots.rb Outdated Show resolved Hide resolved
app/models/robots/plate_to_tube_racks_robot.rb Outdated Show resolved Hide resolved
app/models/robots/tube_rack_wrapper.rb Outdated Show resolved Hide resolved
app/models/robots/tube_rack_wrapper.rb Outdated Show resolved Hide resolved
app/models/robots/tube_rack_wrapper.rb Outdated Show resolved Hide resolved
app/models/robots/tube_rack_wrapper.rb Outdated Show resolved Hide resolved
app/models/robots/tube_rack_wrapper.rb Outdated Show resolved Hide resolved
yoldas and others added 14 commits October 30, 2023 23:43
@yoldas @KatyTaylor
Updated param description in code comments
9a8f1ce 
Co-authored-by: KatyTaylor <[email protected]>
@yoldas
Fixed pushing the tubes supplied as an argument
879e774
@yoldas
Updated code comments of robots controller
6e6c8ac
@yoldas
Updated more code comments of robots controller
ae2a08a
@yoldas
Removed type from robot config relationships
7b80d7c
@yoldas @KatyTaylor
Update app/models/robots/tube_rack_wrapper.rb
be3e7bc 
Co-authored-by: KatyTaylor <[email protected]>
@yoldas @KatyTaylor
Update app/models/robots/plate_to_tube_racks_robot.rb
e836394 
Co-authored-by: KatyTaylor <[email protected]>
@yoldas @KatyTaylor
Update app/models/robots/tube_rack_wrapper.rb
cc5deb6 
Co-authored-by: KatyTaylor <[email protected]>
@yoldas @KatyTaylor
Update app/models/robots/tube_rack_wrapper.rb
1a6ba66 
Co-authored-by: KatyTaylor <[email protected]>
@yoldas @KatyTaylor
Update app/models/robots/tube_rack_wrapper.rb
28f7c67 
Co-authored-by: KatyTaylor <[email protected]>
@yoldas
Removed typo from code comment
5e83c03
@yoldas
Prettier
f7a67f2
@yoldas
Renamed find_or_create_tube_rack to find_or_create_tube_rack_wrapper
ba21795
@yoldas
Updated comments about @tube_positions
bc03b3b
@yoldas yoldas requested a review from KatyTaylor October 31, 2023 09:01
@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 9, 2023

Code Climate has analyzed commit 1e5941a and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 94.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.1% (0.0% change).

View more on Code Climate.

@yoldas yoldas merged commit 01ae90e into develop Nov 15, 2023
8 checks passed
@yoldas yoldas deleted the dpl-829-pbmc-plate-tube-rack-bed-verification branch November 15, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@KatyTaylor KatyTaylor KatyTaylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DPL-829 PBMC plate --> tube rack bed verification
2 participants
@yoldas @KatyTaylor