Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scRNA - fixes for file validations #1453

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Conversation

andrewsparkes
Copy link
Member

Changes:

  1. Refactored sufficient tubes validation to not trigger if csv files are parsed incorrectly

@andrewsparkes andrewsparkes self-assigned this Nov 7, 2023
@andrewsparkes andrewsparkes marked this pull request as ready for review November 8, 2023 15:02
Copy link
Contributor

@emrojo emrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

Copy link

codeclimate bot commented Nov 9, 2023

Code Climate has analyzed commit dde9401 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.0% (0.0% change).

View more on Code Climate.

@andrewsparkes andrewsparkes merged commit a21931b into develop Nov 9, 2023
8 checks passed
@andrewsparkes andrewsparkes deleted the fix_scrna_validations branch November 9, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants