Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-951: Upgrade to Ruby 3 #1454

Merged
merged 12 commits into from
Nov 16, 2023
Merged

DPL-951: Upgrade to Ruby 3 #1454

merged 12 commits into from
Nov 16, 2023

Conversation

emrojo
Copy link
Contributor

@emrojo emrojo commented Nov 6, 2023

Closes #

Changes proposed in this pull request

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codeclimate bot commented Nov 8, 2023

Code Climate has analyzed commit 3f42218 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 68.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that integration suite still runs, that looks good to me 👌
Thanks for the update!

@StephenHulme StephenHulme changed the title Dpl951 ruby 3 DPL-951: Upgrade to Ruby 3 Nov 8, 2023
@KatyTaylor KatyTaylor merged commit 1ee1b44 into develop Nov 16, 2023
13 checks passed
@KatyTaylor KatyTaylor deleted the dpl951_ruby_3 branch November 16, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPL-951 - As PSD we would like to upgrade Limber to Ruby 3 so that we keep up to date with our dependencies
3 participants