Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-812.2: repair undefined method 'value' for nil:NilClass #1464

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

StephenHulme
Copy link
Contributor

Closes #1433

Changes proposed in this pull request

  • Fixes the bug below by using the Safe Navigation Operator.
    An ActionView::Template::Error occurred in exports#show:
    
    undefined method `value' for nil:NilClass
    app/views/exports/pbmc_bank_tubes_content_report.csv.erb:71
    

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme changed the title fix: repair undefined method `value' for nil:NilClass fix: repair undefined method 'value' for nil:NilClass Nov 15, 2023
Copy link

codeclimate bot commented Nov 15, 2023

Code Climate has analyzed commit 495c056 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.0% (0.0% change).

View more on Code Climate.

@StephenHulme StephenHulme changed the title fix: repair undefined method 'value' for nil:NilClass DPL-812.2: repair undefined method 'value' for nil:NilClass Nov 16, 2023
@StephenHulme StephenHulme merged commit 979a6ed into develop Nov 16, 2023
8 checks passed
@StephenHulme StephenHulme deleted the dpl-812-2-missing-values-fix branch November 16, 2023 09:57
@KatyTaylor KatyTaylor linked an issue Nov 16, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPL-812 Transfer PBMC bank data to BioResource team
2 participants