-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-099 plate split to racks #2028
Merged
andrewsparkes
merged 24 commits into
y24-088-tuberacks-epic
from
y24-099-plate-split-to-racks
Nov 27, 2024
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b581f0d
fix typo in comment
andrewsparkes b84e321
added purpose config fields and tube rack relationships
andrewsparkes 909255e
Added tube rack purpose v2 resource
andrewsparkes 85b10fd
Merge branch 'y24-099-tube-rack-banking-sequencescape-api' into y24-0…
andrewsparkes b8bc954
Merge branch 'y24-088-tuberacks-epic' into y24-099-plate-split-to-racks
andrewsparkes 3f85856
checks added to prevent casting inappropriate values
andrewsparkes ae959c0
added specific tube rack creation and related api changes
andrewsparkes 2fa7b50
added check for blank
andrewsparkes b394822
changed redirect to return to parent plate
andrewsparkes f64c55b
added check for tube rack false
andrewsparkes eb600c6
added cached relationship for request type to factory
andrewsparkes e29762a
added methods to fetch aliquots and requests_as_source for tubes in t…
andrewsparkes 4e5b29c
removed unneeded comment
andrewsparkes f2bf2d4
put WellHelpers include back as breaking tests
andrewsparkes 5708619
fixed tests for labware creator
andrewsparkes e934d73
reverted has_one to belongs_to as breaking tests
andrewsparkes bdd0c77
add WellHelpers back into tube rack as using coordinate methods
andrewsparkes f414945
added additional unit tests
andrewsparkes 2c74086
fixed typo
andrewsparkes 715c7ea
fixed test for private method
andrewsparkes 456d986
added comments and added tests for contents_for in TubeRackStateChanger
andrewsparkes c5bb206
Merged develop
andrewsparkes 4a329b2
removed references to tube rack barcode metadata key
andrewsparkes f4eca57
Merge branch 'y24-088-tuberacks-epic' into y24-099-plate-split-to-racks
andrewsparkes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels like this wants to be refactored to:
But again, maybe we can save up refactoring ideas for another story to try to draw a line under this story! Will keep commenting them if I notice and we can decide what to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I think this is building the 'other actions' grey buttons. That could do with some better ordering/structuring in any case.