Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-038 - Changed "Custom Pool Norm" to "Custom Norm" in purposes #2176

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

SHIV5T3R
Copy link
Member

Closes #1656

Changes proposed in this pull request

  • Changed the purpose name for Custom Pool Norm to Custom Norm so it can fit on labels.
  • Custom Pool has not been changed.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.79%. Comparing base (d4d126b) to head (3c226fb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2176   +/-   ##
========================================
  Coverage    80.79%   80.79%           
========================================
  Files          477      477           
  Lines        18202    18202           
  Branches       269      269           
========================================
  Hits         14707    14707           
  Misses        3493     3493           
  Partials         2        2           
Flag Coverage Δ
javascript 74.23% <ø> (ø)
pull_request 80.79% <ø> (ø)
push 80.79% <ø> (-0.01%) ⬇️
ruby 91.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dasunpubudumal dasunpubudumal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but might have to be tested on-site with our printers?

Maybe try to deploy via branch and test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-038 Change printed plate name for LCMB Custom plates
2 participants