Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker variables to keep versions consistent #2180

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

StephenHulme
Copy link
Contributor

The Docker Node version is currently wrong

Changes proposed in this pull request

  • Change node version in docker to 22
  • Make it easier to update the version in the future

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (df9b621) to head (5b08666).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2180   +/-   ##
========================================
  Coverage    80.78%   80.78%           
========================================
  Files          476      476           
  Lines        18185    18185           
  Branches       269      269           
========================================
  Hits         14691    14691           
  Misses        3492     3492           
  Partials         2        2           
Flag Coverage Δ
javascript 74.23% <ø> (ø)
pull_request 80.78% <ø> (-0.01%) ⬇️
push 80.78% <ø> (ø)
ruby 91.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant