Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-1111: Include genome size as estimate_of_bp_required in Traction message #67

Merged

Conversation

sdjmchattie
Copy link
Contributor

Closes #66

Changes proposed in this pull request

  • Accept genome size into the traction requests.
  • Compose the value as estimate_of_bp_required in the API body.
  • Update tests to confirm behaviour.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code

@sdjmchattie sdjmchattie self-assigned this Feb 27, 2024
@sdjmchattie sdjmchattie changed the title Include genome size as estimate of bp required in traction message DPL-1111: Include genome size as estimate_of_bp_required in Traction message Feb 27, 2024
Copy link
Contributor

@stevieing stevieing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change it to genome size in Traction but there is no point at the moment as we will need to change it again.

@sdjmchattie sdjmchattie merged commit 8527738 into develop Mar 1, 2024
4 checks passed
@sdjmchattie sdjmchattie deleted the dpl-1111-compose-genome-size-in-traction-message branch March 1, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPL-1111 Forward genome size from incoming messages to the Traction Service API
2 participants