Better handling of port bind failures #2818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se because that would print the traceback twice.
ahopkins
reviewed
Sep 6, 2023
ahopkins
reviewed
Sep 6, 2023
| p = server_settings["port"] | ||
| if not p or p >= 1024: | ||
| raise | ||
| addr = f"{server_settings['host']}:{p}" |
There was a problem hiding this comment.
Do we care about ipv6 brackets here?
There was a problem hiding this comment.
I should probably add a function in sanic/helpers for that and port numbers as these are getting repeated in many places.
There was a problem hiding this comment.
Are you planning to do that here, or should we make it a new issue to handle on its own?
ahopkins
reviewed
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanic --port 80was printing very ugly error messages.