improved queries with lazy load

saqueib · Aug 30, 2017 · 0cbb078 · 0cbb078
1 parent 12a9d29
commit 0cbb078
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 14 deletions.
diff --git a/app/GraphQL/Query/TweetsQuery.php b/app/GraphQL/Query/TweetsQuery.php
@@ -30,11 +30,11 @@ public function args()
     public function resolve($root, $args)
     {
         if(isset($args['id'])) {
-            $tweet = Tweet::withCount('replies', 'likes')->find($args['id']);
+            $tweet = Tweet::withCount('replies', 'likes')->with('replies')->find($args['id']);
         } else {
             // Get all the latest tweet by followings user
             $followingUser = auth()->user()->following()->pluck('follow_id')->toArray() + [auth()->user()->id];
-            $tweet = Tweet::withCount('replies', 'likes')->whereIn('user_id', $followingUser);
+            $tweet = Tweet::with('user')->withCount('replies', 'likes')->whereIn('user_id', $followingUser);
         }
 
 

diff --git a/app/GraphQL/Query/UserQuery.php b/app/GraphQL/Query/UserQuery.php
@@ -32,7 +32,7 @@ public function resolve($root, $args, $context, ResolveInfo $info)
 
         $fields = $info->getFieldSelection($depth = 3);
 
-        $user = User::query();
+        $user = User::with('tweets', 'tweets.user');
 
         // check for fields
         foreach ($fields as $field => $keys) {
@@ -69,11 +69,6 @@ public function resolve($root, $args, $context, ResolveInfo $info)
             $user = $user->where('id' , $args['id']);
         }
 
-        $user = $user->first();
-
-        // check is current user following it
-        $user->is_following = auth()->user()->isFollowing($user->id);
-
-        return $user;
+        return $user->first();
     }
 }
diff --git a/app/GraphQL/Type/ReplyType.php b/app/GraphQL/Type/ReplyType.php
@@ -45,5 +45,4 @@ protected function resolveCreatedAtField($root, $args)
     {
         return (string) $root->created_at->diffForHumans();
     }
-
 }
diff --git a/app/GraphQL/Type/UserType.php b/app/GraphQL/Type/UserType.php
@@ -50,9 +50,6 @@ public function fields()
             'is_following' => [
                 'type' => Type::boolean()
             ],
-            'is_followed' => [
-                'type' => Type::boolean()
-            ],
             'tweets' => [
                 'args' => [
                     'id' => [
@@ -103,4 +100,8 @@ protected function resolveCreatedAtField($root, $args)
     {
         return (string) $root->created_at->toFormattedDateString();
     }
+
+    protected function resolveIsFollowingField($root) {
+        return auth()->user()->isFollowing($root->id);
+    }
 }
diff --git a/app/Tweet.php b/app/Tweet.php
@@ -24,7 +24,7 @@ public function user()
 
     public function replies()
     {
-        return $this->hasMany(Reply::class)->latest();
+        return $this->hasMany(Reply::class)->with('user')->latest();
     }
 
     public function likes()
-Original file line number
+Diff line change
@@ Expand Up / @@ -45,5 +45,4 @@ protected function resolveCreatedAtField($root, $args) @@
         {
             return (string) $root->created_at->diffForHumans();
         }
     }