Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: self._worker typo in Store, and set daemon threads to true. #1

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

NangWL-Pvt-S
Copy link
Contributor

Hi @sassanh ,

I found 1 typo, and the program cannot quit without daemon threads.

Can you check and merge request?

@sassanh
Copy link
Owner

sassanh commented Feb 19, 2024

Thanks! I review it quickly

redux/main.py Outdated Show resolved Hide resolved
redux/main.py Outdated Show resolved Hide resolved
@sassanh
Copy link
Owner

sassanh commented Feb 19, 2024

Btw, as you are probably the first person who is using this library other than myself, I would really appreciate it if you share your feedback in the form of issues or even better, pull requests.

redux/main.py Outdated Show resolved Hide resolved
@NangWL-Pvt-S
Copy link
Contributor Author

Btw, as you are probably the first person who is using this library other than myself, I would really appreciate it if you share your feedback in the form of issues or even better, pull requests.

I finding redux-like python library to use, some of them are not maintaining anymore.

@NangWL-Pvt-S
Copy link
Contributor Author

Looks like this pull request change nothing at the end 😅

@sassanh sassanh merged commit 3b24676 into sassanh:main Feb 19, 2024
6 checks passed
@sassanh
Copy link
Owner

sassanh commented Feb 19, 2024

Someone had to fix that typo :-)

@sassanh
Copy link
Owner

sassanh commented Feb 19, 2024

Looks like this pull request change nothing at the end 😅

@NangWL-Pvt-S I noticed a similar typo, but this time it was a critical bug that caused autorun to not react to some changes (instead of class scope last_value we were using local scope variable).

It has happened during a refactor I did on the codebase to migrate from create_store closure to Store class. It is now fixed in version 0.10.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants