-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: (IAC-1202) PostgreSQL Transfer Tooling Supplemental Doc #498
Conversation
May also be helpful to add a link to the DAC Postgres section. |
@sayeun, there is a link to the DAC PostgreSQL CONFIG-VARS.md section here in the context of provisioning an external PostgreSQL cluster without using Viya4 IAC projects. Would you suggest adding a DAC PostgreSQL link along with the IAC PostgreSQL links, or elsewhere? |
@sayeun, added "Post" prefix to document .md file name that was missed before. |
@jkmin96, could you review and add comments for concerns or approve this PR if the updated doc content includes the requested changes that we discussed yesterday? |
About title "## PostgreSQL Data Transfer Tool for the SAS Viya Platform - viya4-deployment Post-Transfer Steps (Experimental)" About "### Using IAC to create an external PostgreSQL database server" |
If the expected terraform plan/apply changes that are listed after only adding the PostgreSQL server map to their terraform-input.tfvars include destroying or re-creating a part of the cluster that Viya is currently using, for example substantive changes to existing resources other than the new PostgreSQL database server and recreating the jump server, then stopping Viya first makes sense. If the expected changes are just creating the PostgreSQL database server and jump server, I would not expect stopping Viya to be necessary. Since that advice can be left to some interpretation, perhaps we should always recommend stopping Viya, creating the new PostgreSQL server, then restarting Viya as the way to proceed. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if title is o.k. to include "post" since this doc includes about adding external PG.
Please check if stopping Viya is required when user adds external PGs to an existing cluster using IAC. If not, current doc is o.k.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
default:
entry to reference an external database server by changing it tointernal: false
instead of completely removing the server map entry.