Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (IAC-1485) Update Docker dependency to Resolve issue with requests #553

Merged
merged 3 commits into from
May 29, 2024

Conversation

jarpat
Copy link
Contributor

@jarpat jarpat commented May 22, 2024

Changes

Pin docker==7.1.0 in requirements.txt and community.docker=3.10.3 in requirements.yaml

Resolves an issue found in the docker-py project where the latest version of requests was breaking it.
See info here: docker/docker-py#3256

Summary of issue:

  1. The docker-py project pinned their requirements for the requests dep at ">= 2.26.0"
  2. version 2.32.0 of requests just released on May 20th which broke the docker-py project.
    • This new version renamed a function as a result of some CVE they needed to resolve

Tests

Scenario Provider K8s Version Order Cadence Execution Notes
1 Azure v1.29.4 * fast:2020 ansible on host Ansible, DEPLOY: false, just verifying that docker pull task works again
2 Azure v1.29.4 * fast:2020 ansible inside docker container Docker, DEPLOY: false, doesn't affect this environment, sanity test

@jarpat jarpat self-assigned this May 29, 2024
@jarpat jarpat added bug Something isn't working documentation Improvements or additions to documentation labels May 29, 2024
@jarpat jarpat requested review from thpang and saschjmil May 29, 2024 15:53
@jarpat jarpat changed the title fix: (IAC-1485) Pin requests<=2.31.0 to resolve issue with Docker dep fix: (IAC-1485) Update Docker dependency to Resolve issue with requests May 29, 2024
@dhoucgitter dhoucgitter self-requested a review May 29, 2024 17:15
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@saschjmil saschjmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarpat jarpat merged commit ed60620 into main May 29, 2024
3 checks passed
@jarpat jarpat deleted the IAC-1485 branch May 29, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants