Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (PSKD-1006) Use ingress-nginx v1.12 for K8s 1.31 support #587

Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat: (PSKD-1006) Use ingress-nginx v1.12 for K8s 1.31 support #587

merged 2 commits into from
Jan 7, 2025

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Jan 3, 2025 •
edited
Loading

Changes

  • Update the default version of the ingress-nginx Helm chart to use v4.12.0 for K8s >= v1.28 in order to support K8s 1.31
  • Update the default for INGRESS_NGINX_CHART_VERSION in CONFIG-VARS.md file to be 4.12.0

Tests

Scenario Provider K8s version ingress-nginx chart version Cadence relevant ingress-nginx config map values Notes
1 Azure 1.30.6 (default) 4.12.0 stable:2024.12 annotations-risk-level: Critical Single expected configMap value set for ingress-nginx v1.12.0 at stable:2024.12 cadence
2 Azure 1.30.6 (configured) 4.11.4 stable:2024.12 none No additional ingress-nginx configMap values set for ingress-nginx v1.11.4 at stable:2024.12, matches results for PSKD-1087
3 Azure 1.30.6 (default) 4.12.0 stable:2024.11 strict-validate-path-type: 'false'; annotations-risk-level: Critical Both expected configMap values set for ingress-nginx v1.12.0 at stable:2024.11, matches results for PSKD-1087
4 AWS 1.30.7 (default) 4.12.0 stable:2024.12 annotations-risk-level: Critical Single expected configMap value set for ingress-nginx v1.12.0 at stable:2024.12, matches results for PSKD-1087; Successful Viya4 deployment and viya_admin login to fqdn deploy.aws1.devops.unx.sas.com

@dhoucgitter dhoucgitter self-assigned this Jan 3, 2025
ephesused
ephesused requested changes Jan 3, 2025
View reviewed changes
docs/CONFIG-VARS.md Outdated Show resolved Hide resolved
@dhoucgitter dhoucgitter requested a review from saschjmil January 7, 2025 16:20
@dhoucgitter dhoucgitter added the enhancement New feature or request label Jan 7, 2025
@dhoucgitter dhoucgitter marked this pull request as ready for review January 7, 2025 16:21
@dhoucgitter dhoucgitter requested a review from ephesused January 7, 2025 19:44
@dhoucgitter dhoucgitter merged commit 1b9d0b8 into staging Jan 7, 2025
4 checks passed
@dhoucgitter dhoucgitter deleted the PSKD-1006 branch January 7, 2025 20:16
@saschjmil saschjmil mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iadomi iadomi iadomi approved these changes

@saschjmil saschjmil saschjmil approved these changes

@ephesused ephesused ephesused approved these changes

Assignees

@dhoucgitter dhoucgitter

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhoucgitter @ephesused @saschjmil @iadomi