-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Create dependabot.yml for dependency maintenance #415
base: staging
Are you sure you want to change the base?
Conversation
Signed-off-by: Carus Kyle <[email protected]>
Definitely appreciate the suggestion on how to limit the number of opened PRs per run since if I calculate correctly, this configuration could be as high 15 new PRs weekly. I'd suggest we reduce both the frequency and limit since we can always increase those values once we gauge how well this is working. Also, could you adjust the branch target on your PRs from sassoftware:main to sassoftware:staging. Could you add an example of a test like this if you have an idea for it?
We want to move toward PRs including their own tests as part of acceptance where that's possible. GitHub workflows that run |
I am unsure of the final behaviour when targeting another branch as I have only ever done it on main, but it has this note:
|
Signed-off-by: Carus Kyle <[email protected]>
Updated to two PR's open at a time per scope, and changed target branch to staging |
Hi @Carus11, updating the GitHub workflows to target the |
Done, |
Do you want to build infrastructure with every PR? or run a Is it worth it to do on every PR, or would you rather want to split out: Inidividual PRs:
As part of the steps leading up to release:
I'll admit im not that familiar with |
We are not intending to build infrastructure in github workflows for cost and speed reasons, but do intend to use Don't believe there is any built-in capacity to mock cloud apis, |
I would urge some caution, terraform plan needs a target to plan against, and so I would suspect that means putting secrets into the github project configuration page. I could potentially output those secrets even though github tries to obscure them if I simply base64 them. If this was run automatically without I could potentially swipe cloud credentials before a reviewer would notice. |
To assist in keeping dependencies up to date, this is a sample dependabot.yml configuration file which will seach the terraform modules, docker, and github actions, for external dependencies and open pull requests with those dependencies bumped.
This could be taken further to then run some tests in github actions as part of these pull requests which would automatically test the project with the new dependency version.
To avoid overwhelming the maintainers, the number of pull requests opened each run can be limited, as I have shown in the code with a current limit of 5 for each scope.