chore(deps): update default vm generations off v3

[Carus11]

Fixes #404

The v3 instances are now hidden away in the Microsoft docs under previous and retired generations. The default generation produced by sizing these days are the v5's.

[dhoucgitter]

Hi @Carus11 , expecting that this request would have us update any surviving _v3 references in our sample.*.tfvars files under the examples folder to _v5 types also?

[Carus11]

Good catch, updated those in the branch.
Additionally, I updated the connect sample even though the documentation states:

Note: The functionality associated with the optional Connect workload class has been deprecated and is no longer available in 2024.09 and later.

Thats probably worth of another task to clean it up.

[PhanikumarThodupunoori]

Hi Carus,

Given that the _v5 SKU is not available in many regions, I suggest update the PR to use the _v4 SKU, which is available in most of the regions, to avoid deployment issues. Additionally, the current default values in variables.tf are expected to work across all regions. Setting _v5 SKU as the default conflicts with this expectation.

Please provide your feedback, and let us know if you can update the PR accordingly. Once updated, Please let us know. Thank you!

[Carus11]

Just running through and checking from the product availability graphs,

• Dsv5 has greater availability worldwide than Dsv4
• Esv5 has greater availability worldwide than Esv4

The v5 instances were significantly upgraded in their ability to work with storage over the network. The are a minimum generation version I suggest to customers because of this. The I/O improvements are soo great that I would prefer to leave v5 as the example generation to strive for when available. Its perfectly reasonable for users to adjust the instances to suit their specific constraints when working in one of the few regions with constrained product lists.

[Carus11]

Additionally, the current default values in variables.tf are expected to work across all regions

If this is a requirement, and it is expected to work across all regions, then its probably best leaving them on v3 as that would be the closest method of satisfying it, as its only missing it appears in one region in china, and the one new zealand region which doesnt have many other products listed either.