fix: check for failed state during session log stream to prevent unbounded loop

[smorrisj]

Summary
Check for failed state when streaming the session log to avoid attempting to check for logs in an unbounded loop.

Testing
Steps in #562

[smorrisj]

failed is one of the possible job states that indicates that the request is finished. Add it here so that the while loop will properly terminate on failed jobs.

[smorrisj]

I noticed that after fixing this, we get a rather ugly looking stringified json object rendered in the error message toast. This is due to how we're currently showing error messages for the run command.As part of this PR I'd propose that we come up with a way to clean this up a little. There are a few different error models that we could encounter at this level:

• Axios request errors
• Axios response errors
• Axios error in setting up the request (not the same as the first issue above)
• General typescript/node errors

Based on these possible states it seems like we might need some sort of well known translator that knows how to deal with the possibly different types coming in. Thoughts?

I've looked into making the error display in a modal error message, but it looks fairly different than the usual toast messages. The other tricky part specifically in the expired license case is that the context of the error that tells the user what's going on is actually in the details array, whereas the message value on that case is not very clear.

VSCode's error dialog in the modal option does allow for passing details in a details array. One such approach might be to detect if we are dealing with an error representation, if we are, then see if there are details. On the case of a details array we'd use the modal form. In the case of empty or undefined details array we'd use the normal brief toast message approach. Thoughts?

[smorrisj]

Before State:

Example of what the modal dialog for expired license would look like. Message is the top string and the details array are joined in the detail text below:

Accompanying (rough) code concept out at: main...vscode-modal-error

[scnwwu]

Looks good to me

[scnwwu]

VSCode's error dialog in the modal option does allow for passing details in a details array. One such approach might be to detect if we are dealing with an error representation, if we are, then see if there are details. On the case of a details array we'd use the modal form. In the case of empty or undefined details array we'd use the normal brief toast message approach. Thoughts?

Modal dialog looks good to me. I guess the most tricky part is where's the real detail. I remembered some errors where details is also complex objects.

[smorrisj]

@scnwwu could I trouble you for another review? I pushed some code that switches over to the modal dialog approach discussed further up.

[Zhirong2022]

"Connecting to SAS Session" will not hang when attempting to connect to an expired deployment. And now it will show error 'Request failed with status code 400'.