added obp_evaluation #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashist
reviewed
Aug 17, 2023
| return df1.join(df2) | ||
|
|
||
| @dataclass | ||
| class RePlayOfflinePolicyLearner(BaseOfflinePolicyLearner): |
There was a problem hiding this comment.
Why don't you inherit RePlayOfflinePolicyLearner from both BaseOfflinePolicyLearner and BaseRecommender?
There was a problem hiding this comment.
I can't see if it simplifies the overall logic. I see that it helps to remove logger() function, but it seems that I should hold replay_model inside class anyway. Can you comment more on that?
shashist
reviewed
Aug 17, 2023
Add BayesUCB to DDPG and accelerated the speed of learning See merge request ai-lab-pmo/mltools/recsys/RePlay!94
[CI] Running CI in CI_DEFAULT_BRANCH and publish dev packages See merge request ai-lab-pmo/mltools/recsys/RePlay!103
Fix package registry path See merge request ai-lab-pmo/mltools/recsys/RePlay!104
Move some functionality to experimental part See merge request ai-lab-pmo/mltools/recsys/RePlay!93
Add dataset functionality See merge request ai-lab-pmo/mltools/recsys/RePlay!102
[Feature] Building experimental package See merge request ai-lab-pmo/mltools/recsys/RePlay!108
Add new splitters See merge request ai-lab-pmo/mltools/recsys/RePlay!105
Feature/add new preprocessing See merge request ai-lab-pmo/mltools/recsys/RePlay!111
Update metrics interfaces See merge request ai-lab-pmo/mltools/recsys/RePlay!112
Fix metrics See merge request ai-lab-pmo/mltools/recsys/RePlay!114
Update models interfaces for Dataset concept See merge request ai-lab-pmo/mltools/recsys/RePlay!109
Dependencies updates See merge request ai-lab-pmo/mltools/recsys/RePlay!113
Pyspark - optional dependency See merge request ai-lab-pmo/mltools/recsys/RePlay!116
Add cardinality callback for data nn interfaces See merge request ai-lab-pmo/mltools/recsys/RePlay!140
Change naming of SasRec modules See merge request ai-lab-pmo/mltools/recsys/RePlay!141
Update main branch version to 0.15.1 See merge request ai-lab-pmo/mltools/recsys/RePlay!143
Little fixes in ReadMe See merge request ai-lab-pmo/mltools/recsys/RePlay!144
Add KL-UCB See merge request ai-lab-pmo/mltools/recsys/RePlay!136
levensons
force-pushed
the
feature/obp_eval
branch
from
7e10f7e to
1e29473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added OBP evaluation for cold start models from RePlay. Docs and tests are available but will be further improved. Evaluation is done using class RePlayOfflinePolicyLearner with methods fit, predict and optimize with similar logic as in RePlay. Also script file and config are available for easy run and evaluation of RePlay models on OpenBanditDataset.
To run, for example, UCB algorithm on bts policy you can follow this:
python run_real.py --config=config.py:ucb --config.behavior_policy=bts